fix: handled style change in ServerUrl and ServersOverlay dynamically #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: handled style change in ServerUrl and ServersOverlay dynamically
pranitkhadilkar7
requested review from
AlexVarchuk and
zalesky
and removed request for
a team
AlexVarchuk
requested changes
May 30, 2022
There was a problem hiding this comment.
@pranitkhadilkar7 Hi! Thank you for your contribution to Redoc 🙌 .
It is better to add a new object with these options to rightPanel instead of using sidebar panel options.
Something like that
servers: {
color: 263238,
....
}
|
@AlexVarchuk, thank you for your valuable feedback. I have updated the code as per your review comments. Please do the review and let me know if further changes are required. |
AlexVarchuk
approved these changes
May 31, 2022
There was a problem hiding this comment.
LGTM!
@pranitkhadilkar7 Thank you for the quick update. We very much appreciate your contribution.
Oprysk
approved these changes
May 31, 2022
theme: {
rightPanel: {
servers: {
overlay: { backgroundColor: 'blue', textColor: 'red' },
url: { backgroundColor: 'black' },
},
},
}
|
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: handled style change in ServerUrl and ServersOverlay dynamically
What/Why/How?
Reference
Testing
Screenshots (optional)
Check yourself